Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_glue_crawler Add support for S3 event notifications #21467

Merged
merged 3 commits into from
Oct 25, 2021
Merged

r/aws_glue_crawler Add support for S3 event notifications #21467

merged 3 commits into from
Oct 25, 2021

Conversation

dominik-lekse
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21464

New acceptance tests:

  • TestAccGlueCrawler_S3Target_eventqueue
  • TestAccGlueCrawler_S3Target_dlqeventqueue

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccGlueCrawler_S3Target_eventqueue'
=== RUN   TestAccGlueCrawler_S3Target_eventqueue
=== PAUSE TestAccGlueCrawler_S3Target_eventqueue
=== CONT  TestAccGlueCrawler_S3Target_eventqueue
--- PASS: TestAccGlueCrawler_S3Target_eventqueue (99.28s)
PASS

$ make testacc TESTARGS='-run=TestAccGlueCrawler_S3Target_dlqeventqueue'
=== RUN   TestAccGlueCrawler_S3Target_dlqeventqueue
=== PAUSE TestAccGlueCrawler_S3Target_dlqeventqueue
=== CONT  TestAccGlueCrawler_S3Target_dlqeventqueue
--- PASS: TestAccGlueCrawler_S3Target_dlqeventqueue (147.89s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Oct 24, 2021
github-actions[bot]
github-actions bot reviewed Oct 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @dominik-lekse 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2021
ewbankkit
ewbankkit approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG_NAME=internal/service/glue TESTARGS='-run=TestAccGlueCrawler_'    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run=TestAccGlueCrawler_ -timeout 180m
=== RUN   TestAccGlueCrawler_dynamoDBTarget
=== PAUSE TestAccGlueCrawler_dynamoDBTarget
=== RUN   TestAccGlueCrawler_DynamoDBTarget_scanAll
=== PAUSE TestAccGlueCrawler_DynamoDBTarget_scanAll
=== RUN   TestAccGlueCrawler_DynamoDBTarget_scanRate
=== PAUSE TestAccGlueCrawler_DynamoDBTarget_scanRate
=== RUN   TestAccGlueCrawler_jdbcTarget
=== PAUSE TestAccGlueCrawler_jdbcTarget
=== RUN   TestAccGlueCrawler_JDBCTarget_exclusions
=== PAUSE TestAccGlueCrawler_JDBCTarget_exclusions
=== RUN   TestAccGlueCrawler_JDBCTarget_multiple
=== PAUSE TestAccGlueCrawler_JDBCTarget_multiple
=== RUN   TestAccGlueCrawler_mongoDBTarget
=== PAUSE TestAccGlueCrawler_mongoDBTarget
=== RUN   TestAccGlueCrawler_MongoDBTargetScan_all
=== PAUSE TestAccGlueCrawler_MongoDBTargetScan_all
=== RUN   TestAccGlueCrawler_MongoDBTarget_multiple
=== PAUSE TestAccGlueCrawler_MongoDBTarget_multiple
=== RUN   TestAccGlueCrawler_s3Target
=== PAUSE TestAccGlueCrawler_s3Target
=== RUN   TestAccGlueCrawler_S3Target_connectionName
=== PAUSE TestAccGlueCrawler_S3Target_connectionName
=== RUN   TestAccGlueCrawler_S3Target_sampleSize
=== PAUSE TestAccGlueCrawler_S3Target_sampleSize
=== RUN   TestAccGlueCrawler_S3Target_exclusions
=== PAUSE TestAccGlueCrawler_S3Target_exclusions
=== RUN   TestAccGlueCrawler_S3Target_eventqueue
=== PAUSE TestAccGlueCrawler_S3Target_eventqueue
=== RUN   TestAccGlueCrawler_S3Target_dlqeventqueue
=== PAUSE TestAccGlueCrawler_S3Target_dlqeventqueue
=== RUN   TestAccGlueCrawler_S3Target_multiple
=== PAUSE TestAccGlueCrawler_S3Target_multiple
=== RUN   TestAccGlueCrawler_catalogTarget
=== PAUSE TestAccGlueCrawler_catalogTarget
=== RUN   TestAccGlueCrawler_CatalogTarget_multiple
=== PAUSE TestAccGlueCrawler_CatalogTarget_multiple
=== RUN   TestAccGlueCrawler_disappears
=== PAUSE TestAccGlueCrawler_disappears
=== RUN   TestAccGlueCrawler_classifiers
=== PAUSE TestAccGlueCrawler_classifiers
=== RUN   TestAccGlueCrawler_Configuration
=== PAUSE TestAccGlueCrawler_Configuration
=== RUN   TestAccGlueCrawler_description
=== PAUSE TestAccGlueCrawler_description
=== RUN   TestAccGlueCrawler_RoleARN_noPath
=== PAUSE TestAccGlueCrawler_RoleARN_noPath
=== RUN   TestAccGlueCrawler_RoleARN_path
=== PAUSE TestAccGlueCrawler_RoleARN_path
=== RUN   TestAccGlueCrawler_RoleName_path
=== PAUSE TestAccGlueCrawler_RoleName_path
=== RUN   TestAccGlueCrawler_schedule
=== PAUSE TestAccGlueCrawler_schedule
=== RUN   TestAccGlueCrawler_schemaChangePolicy
=== PAUSE TestAccGlueCrawler_schemaChangePolicy
=== RUN   TestAccGlueCrawler_tablePrefix
=== PAUSE TestAccGlueCrawler_tablePrefix
=== RUN   TestAccGlueCrawler_removeTablePrefix
=== PAUSE TestAccGlueCrawler_removeTablePrefix
=== RUN   TestAccGlueCrawler_tags
=== PAUSE TestAccGlueCrawler_tags
=== RUN   TestAccGlueCrawler_security
=== PAUSE TestAccGlueCrawler_security
=== RUN   TestAccGlueCrawler_lineage
=== PAUSE TestAccGlueCrawler_lineage
=== RUN   TestAccGlueCrawler_reCrawlPolicy
=== PAUSE TestAccGlueCrawler_reCrawlPolicy
=== CONT  TestAccGlueCrawler_dynamoDBTarget
=== CONT  TestAccGlueCrawler_CatalogTarget_multiple
=== CONT  TestAccGlueCrawler_tags
=== CONT  TestAccGlueCrawler_s3Target
=== CONT  TestAccGlueCrawler_catalogTarget
=== CONT  TestAccGlueCrawler_S3Target_exclusions
=== CONT  TestAccGlueCrawler_S3Target_sampleSize
=== CONT  TestAccGlueCrawler_S3Target_eventqueue
=== CONT  TestAccGlueCrawler_S3Target_multiple
=== CONT  TestAccGlueCrawler_S3Target_connectionName
=== CONT  TestAccGlueCrawler_security
=== CONT  TestAccGlueCrawler_reCrawlPolicy
=== CONT  TestAccGlueCrawler_S3Target_dlqeventqueue
=== CONT  TestAccGlueCrawler_RoleARN_noPath
=== CONT  TestAccGlueCrawler_schedule
=== CONT  TestAccGlueCrawler_schemaChangePolicy
=== CONT  TestAccGlueCrawler_RoleName_path
=== CONT  TestAccGlueCrawler_lineage
=== CONT  TestAccGlueCrawler_MongoDBTargetScan_all
=== CONT  TestAccGlueCrawler_RoleARN_path
--- PASS: TestAccGlueCrawler_RoleARN_path (34.57s)
=== CONT  TestAccGlueCrawler_MongoDBTarget_multiple
--- PASS: TestAccGlueCrawler_RoleName_path (40.84s)
=== CONT  TestAccGlueCrawler_removeTablePrefix
--- PASS: TestAccGlueCrawler_RoleARN_noPath (60.38s)
=== CONT  TestAccGlueCrawler_Configuration
--- PASS: TestAccGlueCrawler_S3Target_connectionName (64.40s)
=== CONT  TestAccGlueCrawler_description
=== CONT  TestAccGlueCrawler_classifiers
--- PASS: TestAccGlueCrawler_S3Target_dlqeventqueue (64.71s)
--- PASS: TestAccGlueCrawler_S3Target_eventqueue (68.15s)
=== CONT  TestAccGlueCrawler_disappears
--- PASS: TestAccGlueCrawler_S3Target_exclusions (92.33s)
=== CONT  TestAccGlueCrawler_tablePrefix
--- PASS: TestAccGlueCrawler_schemaChangePolicy (98.82s)
=== CONT  TestAccGlueCrawler_mongoDBTarget
--- PASS: TestAccGlueCrawler_s3Target (100.59s)
=== CONT  TestAccGlueCrawler_jdbcTarget
--- PASS: TestAccGlueCrawler_dynamoDBTarget (100.63s)
=== CONT  TestAccGlueCrawler_JDBCTarget_multiple
--- PASS: TestAccGlueCrawler_security (100.72s)
=== CONT  TestAccGlueCrawler_DynamoDBTarget_scanAll
--- PASS: TestAccGlueCrawler_S3Target_sampleSize (100.91s)
=== CONT  TestAccGlueCrawler_DynamoDBTarget_scanRate
--- PASS: TestAccGlueCrawler_catalogTarget (117.44s)
=== CONT  TestAccGlueCrawler_JDBCTarget_exclusions
--- PASS: TestAccGlueCrawler_disappears (52.15s)
--- PASS: TestAccGlueCrawler_S3Target_multiple (127.75s)
--- PASS: TestAccGlueCrawler_reCrawlPolicy (128.10s)
--- PASS: TestAccGlueCrawler_schedule (129.95s)
--- PASS: TestAccGlueCrawler_removeTablePrefix (92.46s)
--- PASS: TestAccGlueCrawler_tags (134.76s)
--- PASS: TestAccGlueCrawler_MongoDBTargetScan_all (134.90s)
--- PASS: TestAccGlueCrawler_lineage (134.92s)
--- PASS: TestAccGlueCrawler_description (81.00s)
--- PASS: TestAccGlueCrawler_MongoDBTarget_multiple (118.32s)
--- PASS: TestAccGlueCrawler_CatalogTarget_multiple (170.06s)
--- PASS: TestAccGlueCrawler_tablePrefix (86.82s)
--- PASS: TestAccGlueCrawler_mongoDBTarget (85.97s)
--- PASS: TestAccGlueCrawler_jdbcTarget (84.58s)
--- PASS: TestAccGlueCrawler_classifiers (137.94s)
--- PASS: TestAccGlueCrawler_Configuration (151.59s)
--- PASS: TestAccGlueCrawler_JDBCTarget_exclusions (192.50s)
--- PASS: TestAccGlueCrawler_JDBCTarget_multiple (259.03s)
--- PASS: TestAccGlueCrawler_DynamoDBTarget_scanRate (327.75s)
--- PASS: TestAccGlueCrawler_DynamoDBTarget_scanAll (361.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	465.418s

@ewbankkit ewbankkit merged commit 4a4f77b into hashicorp:main Oct 25, 2021
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 25, 2021
@ewbankkit ewbankkit mentioned this pull request Oct 26, 2021
Merged
@dominik-lekse dominik-lekse deleted the f-aws-glue-crawler-s3-event-notifications branch October 26, 2021 13:38
@ewbankkit ewbankkit mentioned this pull request Oct 26, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.

r/aws_glue_crawler Add support for S3 event notifications
3 participants
@dominik-lekse @ewbankkit @justinretzolk